Bug #963

Floating point exceptions

Added by kervala almost 9 years ago. Updated over 8 years ago.

Status:Closed Start date:06/05/2010
Priority:High Due date:
Assignee:kervala % Done:

100%

Category:Client: General
Target version:Version 0.8.0

Description

Under Windows, floating point exceptions (most of them are float with a too high value or division by zero) are ignored but result may be erroneous. We should really fix them.

History

#1 Updated by kervala almost 9 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r282.

#2 Updated by Enoril almost 9 years ago

kervala wrote:

Applied in changeset r282.

Hi Kervala !
With this change, i've an error during Nel library compilation under ubuntu 10.04 x64:

[ 98%] Building CXX object src/sound/driver/CMakeFiles/nelsnd_lowlevel.dir/source.cpp.o
[ 98%] Built target build_rbank
/media/DATA02/ryzom/ryzom_code_linux/code/nel/src/sound/driver/source.cpp: In static member function ‘static sint32 NLSOUND::ISource::computeManualRollOff(sint32, sint32, sint32, double, float, float, float)’:
/media/DATA02/ryzom/ryzom_code_linux/code/nel/src/sound/driver/source.cpp:29: error: ‘numeric_limits’ is not a member of ‘std’
/media/DATA02/ryzom/ryzom_code_linux/code/nel/src/sound/driver/source.cpp:29: error: expected primary-expression before ‘float’
make[2]: *** [src/sound/driver/CMakeFiles/nelsnd_lowlevel.dir/source.cpp.o] Erreur 1
make[1]: *** [src/sound/driver/CMakeFiles/nelsnd_lowlevel.dir/all] Erreur 2
make: *** [all] Erreur 2

#3 Updated by kervala almost 9 years ago

Ok thanks, a #include seems to be missing under Linux :)

#4 Updated by kervala almost 9 years ago

Applied in changeset r283.

#5 Updated by kervala almost 9 years ago

  • Category set to Client: General
  • Target version set to Version 0.8.0

#6 Updated by kervala almost 9 years ago

I found another floating point exception in CEntityCL, _Front was undefined because _CanTurn was initialized after _Front initialization.

#7 Updated by kervala over 8 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF