Bug #890

Ryzom Client Build Fix - _Bool is a keyword in C99 (Patch included)

Added by rti almost 9 years ago. Updated almost 9 years ago.

Status:Closed Start date:05/12/2010
Priority:Normal Due date:
Assignee:kervala % Done:

100%

Category:Build
Target version:Version 0.8.0

Description

Just a small build fix for the Ryzom client.

In interface_options.h the class CInterfaceOptionValue gets a member called "_Bool". This generates compiler errors since _Bool is a keyword in C99.
http://home.datacomm.ch/t_wolf/tw/c/c9x_changes.html#Syntax

I see two options here:
Option 1: undef so that the name is free to use again. (see ryzom_client_bool_name_problem_option_1.patch)
Option 2: rename the member. (see ryzom_client_bool_name_problem_option_2.patch)

I like option 2 better, more code is changed, but it is a cleaner solution.

ryzom_client_bool_name_problem_option_1.patch (453 Bytes) Magnifier rti, 05/12/2010 02:39 pm

ryzom_client_bool_name_problem_option_2.patch (1.3 kB) Magnifier rti, 05/12/2010 02:39 pm

History

#1 Updated by kervala almost 9 years ago

I also prefer the second one because the "bug" is a bad choice of variable name :)

Thanks for the patch :)

#2 Updated by kervala almost 9 years ago

  • Status changed from New to Assigned
  • Assignee set to kervala

#3 Updated by kervala almost 9 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r115.

#4 Updated by kervala almost 9 years ago

  • Target version set to Version 0.8.0

#5 Updated by vl almost 9 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF