Feature #829

Make Ryzom client working with latest liblua, luabind

Added by vl almost 9 years ago. Updated almost 9 years ago.

Status:Closed Start date:05/01/2010
Priority:High Due date:
Assignee:kervala % Done:

100%

Category:Client: General
Target version:Version 0.8.0

Description

Currently, Ryzom client works with liblua 5.0 only.
Version 5.1 compiled but there's some bugs.

luabind-lua.diff (5.6 kB) Magnifier ratmice, 05/08/2010 01:13 am

luabind-diff-2.diff (11.1 kB) Magnifier artart78, 05/09/2010 03:50 pm

History

#1 Updated by ratmice almost 9 years ago

2 things in this patch, lua_dll.cpp changes, lua_dll.cpp was declaring some stuff which lua was providing, but the rest of the file which actually does the symbol copying magic and then trampolining only get run on windows,

so the defines just refrain from declaring anything on non-windows.

lua_ihm.cpp updates to compile with the latest luabind, i'm not entire convinced its implemented correctly (where does the L go?!?)

so... first part of the patch seems right, not sure about the 2nd.

#2 Updated by ratmice almost 9 years ago

so, the luabind portion of that patch aint no good, sorry.

#3 Updated by kervala almost 9 years ago

Feel free to experiments :)

code/ryzom/client/src/interface_v3/lua_ihm.cpp is own big Lua issue :)

#4 Updated by artart78 almost 9 years ago

I made a patch based on ratmice's one. It doesn't compile, but I don't know why at all, so I submit it here anyway, and maybe someone could fix it. The problems is related to enums.

#5 Updated by Letto almost 9 years ago

i got it "working" by commenting out this 2 lines

//LUABIND_ENUM(PVP_CLAN::TPVPClan, "TPVPClan", PVP_CLAN::NbClans, PVP_CLAN::toString)
//LUABIND_ENUM(BONUS_MALUS::TBonusMalusSpecialTT, "TBonusMalusSpecialTT", BONUS_MALUS::NbSpecialTT, BONUS_MALUS::toString)

are these 2 important?

#6 Updated by kervala almost 9 years ago

  • Status changed from New to Assigned
  • Assignee set to kervala
  • Priority changed from Normal to High

#7 Updated by kervala almost 9 years ago

Thanks a lot ratmice and artart78 for providing patches :)

Enums were working fine with little modifications (at least on Windows).

So I updated externals with latest Lua and Luabind versions and put them by default to link with client :)

However, we need to test if all is working as before :)

#8 Updated by kervala almost 9 years ago

  • Subject changed from Make Ryzom client working with latest liblua, luabind, libwww to Make Ryzom client working with latest liblua, luabind
  • Status changed from Assigned to Resolved
  • Target version set to Version 0.8.0
  • % Done changed from 0 to 100

#9 Updated by vl almost 9 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF