Bug #1334

Eliminate hardcoded base URL for WebIG

Added by sfb over 8 years ago. Updated over 7 years ago.

Status:Closed Start date:07/21/2011
Priority:Normal Due date:
Assignee:sfb % Done:

100%

Category:Client: General
Target version:Version 0.9.0

Description

The WebIG code in the client is presently using a hard coded base URL when it is generating and fetching content. This should be moved to a new client config file option. For the sake of backwards compatibility the new config file attribute should not be required and should default to "http://atys.ryzom.com/start/".

interface_v3/action_handler_ui.cpp:                             pGH->setURL("http://atys.ryzom.com/start/index.php?app="+webapp);
interface_v3/group_html_webig.cpp:                      string url = "http://atys.ryzom.com/start/index.php?app=notif&rnd="+randomString();
interface_v3/group_html_webig.cpp://    Home = "http://atys.ryzom.com/start/index.php";
net_manager.cpp:                                contentStr = ucstring("http://atys.ryzom.com/start/")+web_app+ucstring(".php?")+contentStr.substr(i+1);

As a side note it also potentially unfairly makes the assumption that the webapp is always coded in PHP. For the time being this is not a large problem but something to keep in mind if the Ryzom API is ported to other development languages.

webig.patch (9.2 kB) Magnifier ulukyn, 12/20/2011 01:24 am

History

#1 Updated by ulukyn almost 8 years ago

Patch with WebIgMainDomain and WebIgTrustedDomains in config files

#2 Updated by sfb almost 8 years ago

  • Status changed from New to Assigned
  • Assignee set to sfb

Ulukyn,

Thanks for the patch. It seems to work fine but I did have one question. The variable_ WebIgMainDomain_ is read in using READ_STRING_DEV. Is there any reason why we couldn't do read it in using READ_STRING_FV instead? Is there some security justification?

#3 Updated by sfb almost 8 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:ffe4addf53d8.

#4 Updated by kaetemi over 7 years ago

@sfb: Players botting or generally modifying client trough lua code through the ig browser, by making some lua hook into the game loop.

#5 Updated by sfb over 7 years ago

  • Status changed from Resolved to Closed
  • Target version changed from Version 0.10.0 to Version 0.9.0

Also available in: Atom PDF