CMake - improper detection architecture under linux
|Target version:||Version 0.9.0||Estimated time:||1.00 hour|
On both linux 32bits & 64bits, g++ flags -DHAVE_X86 & -DHAVE_X86_64 are missing
It's have probably been introduce in cset 72f92eec5717
#1 Updated by kervala almost 2 years ago
The problem with previous versions was it was checking the host architecture not the target one, so cross compilation was broken.
Now it's checking the size of void* to detect a 32 or 64 bits architecture.
But, currently, I can't check under Linux because I reinstalled my PC.
#2 Updated by Naush almost 2 years ago
Yep I see the trick. having cross compilation is great things
for the moment removing
Works on i686 & x86_64 architecture, don't know if it's works for you
#3 Updated by kervala almost 2 years ago
- Status changed from New to Assigned
- Assignee set to kervala
- Estimated time set to 1.00
Thanks. It seems like CMAKE_SYSTEM_PROCESSOR is empty sometimes, I will comment out it for the moment. We'll be able to add more checks later for other platforms.
#4 Updated by kervala almost 2 years ago
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
Applied in changeset r1475.